stable
Clone or download
When the toolbar is stuck, there is a dropshadow that is displayed as a clue to indicate that there is something under it. But this dropshadow should not span above the table of content. In order to fix this, we have to reorder zindex. This forces us to reverts commit 3e5e4902040e600a358992860613ea16709dd948. So that toolbar image popover is displayed above the table of content. Same strategy is used for section dropdown, in order to display the dropdown above the toc, its menu element is moved in the document body. Dropdown or popover positioning zindex should not depends on z-index nightmare of the inner application. They already have their own z-index that is defined application wize. Maybe we should enhance createDropdown to always move menu elements inside the document body? Part of story #38627: Choice of a new Rich Text Editor Change-Id: I6caef493d558fd465145f5c3b3e0968b01aed279
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/common/connect-popover.test.ts | +22 | −8 | Go to diff View file |
| M | lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/common/connect-popover.ts | +14 | −1 | Go to diff View file |
| M | lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/image/image.ts | +1 | −2 | Go to diff View file |
| M | lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/link/link.ts | +1 | −2 | Go to diff View file |
| M | plugins/artidoc/scripts/artidoc/src/components/DocumentLayout.vue | +3 | −0 | Go to diff View file |
| M | plugins/artidoc/scripts/artidoc/src/components/section/SectionContent.vue | +0 | −1 | Go to diff View file |
| M | plugins/artidoc/scripts/artidoc/src/components/section/header/SectionDropdown.test.ts | +1 | −0 | Go to diff View file |
| M | plugins/artidoc/scripts/artidoc/src/components/section/header/SectionDropdown.vue | +14 | −4 | Go to diff View file |
| A | plugins/artidoc/scripts/artidoc/src/helpers/move-dropdownmenu-in-document-body.ts | +22 | −0 | Go to diff View file |
| M | plugins/artidoc/scripts/artidoc/src/themes/includes/_zindex.scss | +8 | −5 | Go to diff View file |