Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix(webdav): request #25321 WebDAV support broken at PROPFIND

Download Browse

Original implementation was relying on extend of Dav\Directory & File that supposed to be a wrapper for a filesystem exposed via WebDav. However in our case it's not an actuall filesystem but an abstraction so we should actually implement the interfaces instead of extending. This solves the issue raised in the request because: - we no longer implements IQuota so it won't trigger the issue - the code for the generic method were expecting a $path to be initialized but as 100% of our extends were not calling parent constructor the code was broken (issue visible with PHP 8.0 argument check for internal methods). Change-Id: I26b841c6927aed0813270bea651675c9ae2d2768

+164 −152
Manuel Vacelet (vaceletm) 2022-01-27 10:16
Manuel Vacelet (vaceletm) 2022-02-02 17:20
00bbbf08ca3096c24438c164bf19749eea480299
16c0aabbe09bb8a66b8b1d060f6f330655d1add3
git #tuleap/stable/00bbbf08ca3096c24438c164bf19749eea480299

Modified Files

Side by side diff
Inline diff
Name
M plugins/webdav/include/FS/WebDAVDocmanFile.class.php +9 −29 Go to diff View file
M plugins/webdav/include/FS/WebDAVDocmanFolder.class.php +8 −24 Go to diff View file
M plugins/webdav/include/FS/WebDAVFRS.class.php +27 −4 Go to diff View file
M plugins/webdav/include/FS/WebDAVFRSFile.class.php +8 −23 Go to diff View file
M plugins/webdav/include/FS/WebDAVFRSPackage.class.php +18 −1 Go to diff View file
M plugins/webdav/include/FS/WebDAVFRSRelease.class.php +18 −1 Go to diff View file
M plugins/webdav/include/FS/WebDAVProject.class.php +37 −26 Go to diff View file
M plugins/webdav/include/FS/WebDAVRoot.class.php +39 −44 Go to diff View file