stable
Clone or download
Read-only
Comments order should now match the one in Tracker artifact view (previously it was reversed). There is now a little spinner icon to show that the comments are loading. The error message when loading comments shows up in the modal feedback section (which is visible even when scrolling to the bottom). It is also a bit more detailed. No other functional change expected in edition modal: - When there are no comments, an empty state is shown. - Relative date / absolute date user preference is respected. - Edited comments show the user editing them and the last update date. - Anonymous users don't have a comment input (they cannot write a new comment). - Tooltips are still shown on existing comments only (not new comments). They are not more broken than before. - New comments are still saved. - It's still possible to upload an image in HTML comment (with a File field present in the tracker). part of request #22648 Convert AngularJS directives and controllers to hybrids web components Change-Id: I1efcef35b5b17272f4cf9cfd68b8212252642578
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tracker/scripts/lib/artifact-modal/package.json | +1 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/pnpm-lock.yaml | +2 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/po/fr_FR.po | +6 | −3 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/po/pt_BR.po | +4 | −1 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/ProjectIdentifierProxy.test.ts | +33 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/ProjectIdentifierProxy.ts | +28 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TrackerShortnameProxy.ts | +1 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.test.ts | +65 | −2 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.ts | +22 | −2 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/comments/FollowUpCommentProxy.test.ts | +133 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/comments/FollowUpCommentProxy.ts | +66 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/CommentTemplate.test.ts | +137 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/CommentTemplate.ts | +116 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/CommentsPresenter.ts | +43 | −0 | Go to diff View file |
| R | plugins/tracker/scripts/lib/artifact-modal/src/followups/FollowupEditor.test.ts | Go to diff View file | ||
| R | plugins/tracker/scripts/lib/artifact-modal/src/followups/FollowupEditor.ts | Go to diff View file | ||
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.test.ts | +166 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.ts | +138 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/_comments.scss | +137 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.test.ts | +2 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.ts | +6 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/ProjectIdentifier.ts | +23 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentUserPreferences.ts | +31 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.test.ts | +91 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.ts | +55 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsRetrievalFault.ts | +25 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/FollowUpComment.ts | +47 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/NewComment.ts | +25 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/RetrieveComments.ts | +30 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/gettext-catalog.ts | +7 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/rest/rest-service.test.ts | +0 | −45 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/rest/rest-service.ts | +0 | −34 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js | +20 | −41 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.test.js | +6 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-service.js | +5 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-service.test.js | +19 | −2 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.js | +1 | −2 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.scss | +2 | −123 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.tpl.html | +7 | −71 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/builders/ChangesetWithCommentRepresentationBuilder.ts | +121 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/builders/CommentUserPreferencesBuilder.ts | +83 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/builders/FollowUpCommentBuilder.ts | +86 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/stubs/CommentAuthorStub.ts | +40 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ProjectIdentifierStub.ts | +27 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/stubs/RetrieveCommentsStub.ts | +40 | −0 | Go to diff View file |