stable
Clone or download
Read-only
part of story #29240 reply to pull request comment How to test: - Toggle the comment form --> The Reply button is disabled - Type something in the textarea --> The Reply button is not disabled anymore - Submit --> Both Cancel and Reply buttons are disabled while the comment is being saved --> The Reply button has a spinner --> The form is hidden when the comment has been saved --> The comment is displayed below its parent - It works with inline-comments and global comments on the timeline view and with file-diff-comments in the file-diff view Change-Id: Ifeb295755ec36617702cb765d551c4d3d93aa5d9
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/include/PullRequest/InlineComment/Dao.php | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/InlineComment/InlineComment.php | +8 | −1 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/REST/v1/PaginatedTimelineRepresentationBuilder.php | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/REST/v1/TimelineInlineCommentRepresentation.php | +17 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/package.json | +3 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/pnpm-lock.yaml | +10 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts | +19 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentBodyTemplate.test.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentBodyTemplate.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.test.ts | +90 | −10 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.ts | +53 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentFooterTemplate.ts | +3 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.test.ts | +39 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.ts | +61 | −16 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentRepliesStore.test.ts | +28 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentRepliesStore.ts | +39 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplyFormTemplate.test.ts | +84 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplyFormTemplate.ts | +31 | −4 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplySaver.test.ts | +100 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplySaver.ts | +89 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCurrentUserPresenter.test.ts | +3 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCurrentUserPresenter.ts | +5 | −1 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestPresenter.test.ts | +33 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestPresenter.ts | +34 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/ReplyCommentFormPresenter.test.ts | +84 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/ReplyCommentFormPresenter.ts | +54 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js | +11 | −5 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-controller.js | +8 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline.tpl.html | +1 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CurrentPullRequestPresenterStub.ts | +26 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CurrentPullRequestUserPresenterStub.ts | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentControllerStub.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentPresenterStub.ts | +33 | −12 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/ReplyCommentFormPresenterStub.ts | +68 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/SaveNewCommentStub.ts | +54 | −0 | Go to diff View file |
| D | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/StorePullRequestCommentRepliesStub.ts | +0 | −58 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/InlineCommentRetrieverTest.php | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/InlineCommentUpdaterTest.php | +7 | −7 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/Notification/InlineCommentCodeContextExtractorTest.php | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/Notification/PullRequestNewInlineCommentNotificationTest.php | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilderTest.php | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/REST/v1/Comment/ParentIdValidatorForInlineCommentTest.php | +4 | −2 | Go to diff View file |