stable
Clone or download
Read-only
request #19296 : pressing the `enter` key on modal top close button should close modal
Some modal cannot be closed by pressing `enter` on top-right close button `×`. -> Using semantic <button> element means that there is no need to make the `close` element focusable and to define event handler for `enter` keydown events. Live examples can be seen in Shortcuts and Invite Buddies modals. Other modals should be changed little by little. This patch also prevents close button to be the first focused element when opening a modal. Change-Id: I5c002975e26b21062a10e6912717a3f280f2b203
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/themes/BurningParrot/templates/help-dropdown.mustache | +2 | −2 | Go to diff View file |
| M | src/themes/BurningParrot/templates/invite-buddies-modal.mustache | +3 | −4 | Go to diff View file |
| M | src/themes/tlp/src/js/modal.ts | +1 | −1 | Go to diff View file |
| M | src/themes/tlp/src/scss/components/_modal.scss | +4 | −0 | Go to diff View file |
| M | src/www/tlp-doc/resources/flyover/modals/open-target/example.html | +1 | −1 | Go to diff View file |
| M | src/www/tlp-doc/resources/flyover/modals/replace-placeholders/example.html | +1 | −1 | Go to diff View file |
| M | src/www/tlp-doc/resources/flyover/modals/structure/example.html | +4 | −4 | Go to diff View file |
| M | src/www/tlp-doc/resources/flyover/modals/types/example.html | +12 | −12 | Go to diff View file |
| M | src/www/tlp-doc/resources/flyover/modals/usage/example.html | +8 | −8 | Go to diff View file |