Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: extract fields to be saved in method

Download Browse

No functional changes. Later we will need to save fields in a specific order. To avoid proposing a too big changeset, this one only deal with moving duplicate usage of formelement factory in one unique method. As a bonus, declare return types Part of story #13453: finish drag'n drop images in tracker text areas Change-Id: I58637f411f7c8c9edd09b2da467f5627ca5ea16f

+74 −54
Nicolas Terray (nterray) 2019-06-05 17:10
Nicolas Terray (nterray) 2019-06-06 13:24
07f0ec8534779904bcae245c636a932c73463972
8b088c174232a70a5c1011f748bb19bc04415c70
git #tuleap/stable/07f0ec8534779904bcae245c636a932c73463972

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/Changeset/ChangesetCreatorBase.class.php +19 −11 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/InitialChangesetAtGivenDateCreator.class.php +4 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/InitialChangesetCreator.class.php +6 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/InitialChangesetCreatorBase.class.php +22 −15 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetAtGivenDateCreator.class.php +3 −6 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.class.php +3 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreatorBase.class.php +15 −12 Go to diff View file
M plugins/tracker/tests/Artifact/Changeset/InitialChangesetCreatorTest.php +2 −2 Go to diff View file