Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Use CSS custom properties instead of Sass for-loops

Download Browse

Part of story #14249 Taskboard technical improvements No functional change expected. It decreases the size of the generated .css file from 92KiB to 50KiB. Loops using mix() or darken() or the ease-out-background could not be removed because they rely on SASS functions to alter the variables. The "taskboard-card-*" and "taskboard-card-background-*" have also been kept but we could find a clever way to use "tlp-swatch-*" class instead. Change-Id: I7f0042ce742813556c922b4c37c46a4eac4eacc1

+454 −318
Joris MASSON (jmasson) 2019-12-02 17:45
Joris MASSON (jmasson) 2019-12-03 14:55
084d568b95236d27d3f02b2a2ec74a1fae52b70c
5ab54a8a52fca72239e546843eb21f118ed712db
git #tuleap/stable/084d568b95236d27d3f02b2a2ec74a1fae52b70c

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/CardXrefLabel.test.ts +1 −3 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/CardXrefLabel.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ParentCard.vue +1 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ParentCardRemainingEffort.test.ts +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ParentCardRemainingEffort.vue +1 −4 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/RemainingEffort/EditRemainingEffort.test.ts +2 −6 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/RemainingEffort/EditRemainingEffort.vue +2 −4 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/__snapshots__/CardXrefLabel.test.ts.snap +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/CollapsedSwimlane.vue +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Header/SwimlaneHeader.test.ts +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Header/SwimlaneHeader.vue +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/__snapshots__/CollapsedSwimlane.test.ts.snap +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Header/Collapsed/CollapsedHeaderCell.test.ts +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Header/Expanded/ExpandedHeaderCell.test.ts +5 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Header/header-cell-mixin.ts +1 −1 Go to diff View file
M plugins/taskboard/themes/includes/_body.scss +2 −4 Go to diff View file
M plugins/taskboard/themes/includes/_card-edit.scss +4 −20 Go to diff View file
M plugins/taskboard/themes/includes/_card-read.scss +34 −51 Go to diff View file
M plugins/taskboard/themes/includes/_header.scss +5 −12 Go to diff View file
M src/www/themes/common/tlp/src/scss/variables/colors/_common-colors.scss +386 −193 Go to diff View file