Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Edit link type for existing links

Download Browse

How to test: - open the modal by editing an existing artifact (that already has links) - when you change the type of an existing link, it is saved correctly in backend - you cannot choose `_mirrored_milestone` type - existing links with `_mirrored_milestone` type are readonly: they cannot be edited nor deleted - when the artifact already has a parent, then "is Child of" type is disabled - if you change the type of an existing parent ("is Child of" type) to something else, you can once again choose "is Child of" in the selector You should not be able to add two parents by changing the type of links. part of story #24970 [modal] select type for links Change-Id: I104b8c023d616e8cf85f62505c04c4d51afe7f6c

+389 −191
Joris MASSON (jmasson) 2023-03-17 09:59
Joris MASSON (jmasson) 2023-03-17 13:02
08764bfd7f76069c73be79529c3749213843f3a0
90ffe68f2dae00f759445f17557dc5037321eea7
git #tuleap/stable/08764bfd7f76069c73be79529c3749213843f3a0

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/Memory/fields/link-field/LinksStore.test.ts +24 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/Memory/fields/link-field/LinksStore.ts +14 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/Memory/fields/link-field/NewLinksStore.test.ts +4 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.test.ts +41 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.ts +16 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.test.ts +101 −62 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.ts +68 −44 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.test.ts +3 −42 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.ts +2 −21 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/link-field.scss +3 −7 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/ChangeLinkType.ts +25 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/LinkedArtifact.test.ts +33 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/LinkedArtifact.ts +7 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/NewLink.test.ts +11 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +1 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ChangeLinkTypeStub.ts +36 −0 Go to diff View file