stable
Clone or download
If refresh of the card takes times to proceed, then the new assignee are not displayed (whereas the new label is). In order to remove this confusion, the new assignee should be displayed as soon as possible. You can test that with a `sleep()` in `\Tuleap\Taskboard\REST\v1\TaskboardCardResource::getId()` Implementation notes -------------------- We could have achieved the same result without having to change the whole `new_assignees_ids` chain, because the possible assignees are cached by the store and the new assignees can therefore be retrieved by card-actions. However this would force us to declare another payload for card-mutation. As of today `card-mutation:finishSavingCard()` and `card-actions:saveCard()` are sharing the same UpdateCardPayload and IMHO we should stick to it for now. Furthermore using real objects instead of primitive is not that bad. PeoplePicker still return list of ids, because it does only know about UserForPeoplePicker, not User. We could return a list of UserForPeoplePicker and let CardAssignees do the conversion to list of User, however I don't think it is really worth it. Part of: story #14151 Update the assigned-to semantic of a card Change-Id: Ib4e4c9af7ca1311de2ab5a4a7d65cb6098ffada9
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/BaseCard.test.ts | +4 | −4 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/BaseCard.vue | +6 | −9 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/CardAssignees.vue | +8 | −5 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/CardInfo.vue | +5 | −5 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/helpers/have-assignees-changed.test.ts | +12 | −12 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/helpers/have-assignees-changed.ts | +6 | −4 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/helpers/update-artifact.test.ts | +1 | −1 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/helpers/update-artifact.ts | +4 | −9 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-actions.test.ts | +3 | −3 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-mutations.test.ts | +5 | −3 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/store/swimlane/card/card-mutations.ts | +1 | −0 | Go to diff View file |
M | plugins/taskboard/scripts/taskboard/src/store/swimlane/card/type.ts | +2 | −2 | Go to diff View file |