Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove direct inclusion of jpgraph.php in class files

Download Browse

The direct inclusions have been added in 1b14ec815dd92eb78972e4be8d7a8c7d307dccd8 to solve Psalm issues that are caused by the convoluted way JPGraph is loading its symbols. This contribution rollbacks to the old way and just ignore the errors. Directly including jpgraph.php from class files is not fine because it redefines the error handler which can cause unit tests to pass when they should be failing. Psalm is right about the issues and both situations are not great so let's use the less annoying for now. Part of request #17148: Tracker move to PSR4 Change-Id: I5087f38559a926e30475ea1eaa8501db4e557dc8

+17 −44
Thomas Gerbet (tgerbet) 2020-12-03 10:27
Thomas Gerbet (tgerbet) 2020-12-03 10:38
0ae99239e031f83707a2924305962742c4eae5d5
3e0d8e3fcac267593e34a02e346dc39376c966d0
git #tuleap/stable/0ae99239e031f83707a2924305962742c4eae5d5

Modified Files

Side by side diff
Inline diff
Name
M plugins/graphontrackersv5/include/graphic-library/GraphOnTrackersV5_Engine_Bar.class.php +0 −2 Go to diff View file
M plugins/statistics/include/Frequencies/GraphDataBuilders/SampleGraph.php +0 −2 Go to diff View file
M plugins/tracker/include/Tracker/Chart/Burndown.class.php +0 −2 Go to diff View file
M plugins/tracker/include/Tracker/Chart/BurndownView.class.php +0 −2 Go to diff View file
M tests/psalm/tuleap-baseline.xml +17 −36 Go to diff View file