stable
Clone or download
Read-only
request #13068: Start enforcing Tuleap PHP coding standard in CI pipelines
Usage of PHP short open tags are now rejected by the CI pipeline and the whole codebase is fixed for this issue. Two new helpers has been to the Makefile at the sources root to help contributors launch phpcs and phpcbf. To get a quick result, only the files modified by a contribution are tested. The test pipeline will however check the whole codebase when played against the master branch to help catching bad merges. Change-Id: I4b089fe43aa1ebee65c94903392654b3a3b878b6
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | Makefile | +9 | −0 | Go to diff View file |
| M | site-content/en_US/layout/footer_about.php | +2 | −2 | Go to diff View file |
| M | site-content/en_US/layout/footer_cli.php | +1 | −1 | Go to diff View file |
| M | site-content/fr_FR/layout/footer_about.php | +2 | −2 | Go to diff View file |
| M | site-content/fr_FR/layout/footer_cli.php | +1 | −1 | Go to diff View file |
| M | src/common/layout/Layout.class.php | +3 | −3 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi-light-printer-version/hyperapplet.php | +5 | −5 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi-light-printer-version/hyperwiki.php | +4 | −4 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi-lite/hyperapplet.php | +5 | −5 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi-lite/hyperwiki.php | +4 | −4 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi/hyperapplet.php | +5 | −5 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Codendi/hyperwiki.php | +4 | −4 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/Sidebar/clock.php | +2 | −2 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/default/hyperapplet.php | +5 | −5 | Go to diff View file |
| M | src/common/wiki/phpwiki/themes/default/hyperwiki.php | +4 | −4 | Go to diff View file |
| M | src/composer.json | +1 | −1 | Go to diff View file |
| M | src/composer.lock | +6 | −6 | Go to diff View file |
| M | src/www/account/change_pw.php | +23 | −11 | Go to diff View file |
| M | src/www/admin/show_pending_documents.php | +9 | −9 | Go to diff View file |
| M | src/www/file/file_utils.php | +2 | −2 | Go to diff View file |
| M | src/www/include/help.php | +20 | −9 | Go to diff View file |
| M | src/www/include/user.php | +7 | −7 | Go to diff View file |
| M | src/www/my/redirect.php | +1 | −1 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/index.php | +19 | −19 | Go to diff View file |
| M | src/www/tracker/group_selection.php | +27 | −16 | Go to diff View file |
| M | src/www/tracker/tracker_selection.php | +30 | −18 | Go to diff View file |
| M | tests/Jenkinsfile | +16 | −0 | Go to diff View file |
| M | tests/actions.groovy | +7 | −0 | Go to diff View file |
| A | tests/helpers.groovy | +12 | −0 | Go to diff View file |
| A | tests/phpcs/tuleap-ruleset-minimal.xml | +15 | −0 | Go to diff View file |
| A | tests/phpcs/tuleap-ruleset.xml | +15 | −0 | Go to diff View file |
| M | tests/simpletest/common/backend/_fixtures/iterator_test/dir1/file1.html.php | +1 | −0 | Go to diff View file |
| M | tests/simpletest/common/backend/_fixtures/iterator_test/dir1/file1.php | +1 | −0 | Go to diff View file |
| M | tests/simpletest/common/backend/_fixtures/iterator_test/file0.php | +1 | −0 | Go to diff View file |
| M | tests/simpletest/common/backend/_fixtures/post-revprop-change.php | +1 | −0 | Go to diff View file |
| M | tools/utils/githooks/pre-commit-02-phpcs | +15 | −3 | Go to diff View file |