Requests for project administration has been defined with variable name `id` for the project id. Latest developments that needed a middleware to retrieve a project are using `project_id` (See `ProjectRetrieverMiddleware`). If we want to be able to use this middleware in project administration pages (e.g in upcoming contribution about invitations management) then we should rename the existing variable `id` to `project_id`. Another solution would have been to be able to use both `id` and `project_id` in `ProjectRetrieverMiddleware`, but it looks like dangerous if a route is using both for two different things. We could have added an additional middleware like `ProjectByIdRetriever` that would use `id` instead of 'project_id`, but the less classes we have similar behavior, the better IMHO. No functional changes are expected in project/:id/admin pages declared in `RouteCollector::collect`. Part of story #30021: Invite buddies to my Tuleap project Change-Id: I8da40a40f3507e64ac2e13c58244fa62a94abf42

+47 −47

Author

Nicolas Terray (nterray) 2023-02-06 17:16

Committer

Nicolas Terray (nterray) 2023-02-07 10:30

Hash 0baff3b048ef50a22dc00debde10e55cb421d405

Parent e06c3d7e716fc7bb2b3c7601ca664662c80b6eaa

Reference git #tuleap/stable/0baff3b048ef50a22dc00debde10e55cb421d405