stable

Clone or download

Read-only

refactor: MappedValuesRetriever returns Option

part of request #39022 Moving a card in Taskboard can have side effects No functional change. Unit and REST tests should pass. Why? This series of refactorings has the goal to make it easy to write a "domain" API to find the current column of a given card. This requires us to know which list bind values in the card's "mapped" field are associated to a given column. We continue by simplifying the retrieval of the mapped values. Change-Id: I212bc217b8591a3c5733ee3e1aef05f6bb36e361

Modified Files

Name
M plugins/taskboard/include/Column/ColumnPresenterCollectionRetriever.php +19 −1 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/MappedValuesRetriever.php +19 −17 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/TrackerMappingPresenterBuilder.php +13 −42 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +30 −23 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappedFieldValuesRetrieverTest.php +17 −12 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/SearchMappedFieldStub.php +8 −5 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/SearchMappedFieldValuesForColumnStub.php +32 −5 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/MappedValuesRetrieverTest.php +36 −32 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/TrackerMappingPresenterBuilderTest.php +46 −53 Go to diff View file
M plugins/taskboard/tests/unit/REST/v1/Cell/CardMappedFieldUpdaterTest.php +38 −42 Go to diff View file