stable
Clone or download
Read-only
When ldap is installed but git is not, the former is failing to listen to `GerritCanMigrateChecker::GIT_EVENT_PLATFORM_CAN_USE_GERRIT` causing the application to crash. Introduced by git #tuleap/stable/d6aacaf3210b2548ac425166640270a339929525 To solve the issue we convert to an object instead of a constant, because it is not possible to detect if a constant exist when it is passed as an attribute parameter. Took the opportunity to fix the namespace of GerritCanMigrateChecker and to remove Mockery from its test. Part of request #31547: Simplify hook listening for plugins Part 2 Change-Id: I2cb1b9b51fec872d37a11e0b0df0721783d9ae78
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/include/Git.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git/RemoteServer/GerritCanMigrateChecker.php | +11 | −35 | Go to diff View file |
| A | plugins/git/include/Git/RemoteServer/GerritCanMigrateEvent.php | +38 | −0 | Go to diff View file |
| M | plugins/git/include/GitActions.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitViews/RepoManagement/Pane/Gerrit.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitViews/RepoManagement/RepoManagement.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/gitPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/Git/RemoteServer/GerritCanMigrateCheckerTest.php | +45 | −73 | Go to diff View file |
| M | plugins/git/tests/unit/GitActionsDeleteTest.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/GitActionsFetchConfigTest.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/GitActionsForkTest.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/GitActionsTest.php | +2 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/GitGerritRouteTest.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/include/ldapPlugin.php | +4 | −4 | Go to diff View file |