Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add a warning when viewing a file in a PR containing potentially dangerous bidirectional characters

Download Browse

For now only a warning is added. Later on, we could improve a bit the behavior and make the caracters visible in the CodeMirror view. Part of request #23496: Add warnings when displaying code with bidirectional Unicode text in Git/PR web UI Change-Id: I3132827890f8fa64133f38ec2718d5a85d91f06f

+139 −1
Thomas Gerbet (tgerbet) 2021-11-05 15:35
Thomas Gerbet (tgerbet) 2021-11-05 15:56
0f6f8e46b091876efa40f0f38c362396173182ae
5ec496d52d8e2d76f853279e13c0c9eccfac7495
git #tuleap/stable/0f6f8e46b091876efa40f0f38c362396173182ae

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/po/fr.po +12 −0 Go to diff View file
A plugins/pullrequest/scripts/src/app/file-diff/diff-bidirectional-unicode-text.test.ts +52 −0 Go to diff View file
A plugins/pullrequest/scripts/src/app/file-diff/diff-bidirectional-unicode-text.ts +54 −0 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/file-diff-component.js +4 −0 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/file-diff.tpl.html +8 −0 Go to diff View file
M plugins/pullrequest/webpack.common.js +9 −1 Go to diff View file