Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: convert assoc array to presenter object

Download Browse

The form elements used to create a new template will be the same than the one to update a template. In order to have a common base and not repeat ourselves those form elements are extracted in a dedicated mustache file. A template presenter dedicated to the creation is injected instead of directly its styles. Took the opportunity to convert the associative array used as a presenter to an object. No functional changes in template creation. Part of story #38630: Export to file Change-Id: I2e5e2b4cd6b59b0e1e81eba4ff6018a07c692b11

+104 −46
Nicolas Terray (nterray) 2024-07-11 10:28
Nicolas Terray (nterray) 2024-07-11 10:28
102efca282053d9db92e8efb6ec474019a9fdaac
6a5748ee5fa9c67908f6dbc1fc67a9ecf7f31432
git #tuleap/stable/102efca282053d9db92e8efb6ec474019a9fdaac

Modified Files

Side by side diff
Inline diff
Name
M plugins/pdftemplate/include/PdfTemplate/Admin/DisplayPdfTemplateCreationFormController.php +6 −7 Go to diff View file
A plugins/pdftemplate/include/PdfTemplate/Admin/DisplayPdfTemplateCreationFormPresenter.php +43 −0 Go to diff View file
M plugins/pdftemplate/include/PdfTemplate/Admin/IndexPdfTemplatePresenter.php +1 −1 Go to diff View file
M plugins/pdftemplate/include/PdfTemplate/Admin/PdfTemplatePresenter.php +13 −1 Go to diff View file
M plugins/pdftemplate/include/PdfTemplate/Admin/create.mustache +1 −37 Go to diff View file
A plugins/pdftemplate/include/PdfTemplate/Admin/template-form-elements.mustache +40 −0 Go to diff View file