stable
Clone or download
Read-only
In order to have some control on the way the default svn block is generated (to remove default [/]), let's start by extracting the code from BackendSVN so we can re-use it elsewhere eventually. As a side-effect, the ignominious LDAP_BackendSVN is gone. Psalm baseline is updated because of usage of deprecated dao in the LDAP part and I thought it was not part of this war to rewrite those DAO as well. It's a pure refactoring, nothing should change. You can test it by adding/removing people from projects & groups and ensure the .SVNAccessFile is still consistent. Part of: request #31541 svn 1.10+ no longer supports duplicate sections Change-Id: Ie01a654deefe015b3985a7e0e47724bbfde0e9a5
Modified Files
Name | ||||
---|---|---|---|---|
D | plugins/ldap/include/LDAP_BackendSVN.class.php | +0 | −207 | Go to diff View file |
M | plugins/ldap/include/LDAP_UserDao.class.php | +1 | −1 | Go to diff View file |
A | plugins/ldap/include/SVN/SVNUserGroupsProvider.php | +73 | −0 | Go to diff View file |
M | plugins/ldap/include/ldapPlugin.php | +8 | −11 | Go to diff View file |
M | src/common/Project/Project.class.php | +0 | −6 | Go to diff View file |
M | src/common/Project/ProjectUGroup.php | +8 | −2 | Go to diff View file |
M | src/common/Project/UGroupManager.class.php | +4 | −6 | Go to diff View file |
M | src/common/Project/UGroupRetriever.php | +6 | −0 | Go to diff View file |
A | src/common/SVNCore/GetSVNUserGroups.php | +57 | −0 | Go to diff View file |
A | src/common/SVNCore/SVNUser.php | +39 | −0 | Go to diff View file |
A | src/common/SVNCore/SVNUserGroup.php | +64 | −0 | Go to diff View file |
A | src/common/SVNCore/SvnAccessFileDefaultBlockGenerator.php | +127 | −0 | Go to diff View file |
M | src/common/backend/BackendFactory.class.php | +0 | −18 | Go to diff View file |
M | src/common/backend/BackendSVN.class.php | +4 | −133 | Go to diff View file |
M | tests/lib/Builders/ProjectUGroupTestBuilder.php | +31 | −1 | Go to diff View file |
M | tests/lib/Stubs/UGroupRetrieverStub.php | +9 | −0 | Go to diff View file |
M | tests/psalm/tuleap-baseline.xml | +6 | −35 | Go to diff View file |
D | tests/unit/common/Backend/BackendSVNTest.php | +0 | −135 | Go to diff View file |
A | tests/unit/common/SVNCore/SvnAccessFileDefaultBlockGeneratorTest.php | +147 | −0 | Go to diff View file |