Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: use HTTP header to check webhook type

Download Browse

This is part of request #20918 GitLab tags that contains a reference to Tuleap should be backlinked Webhook content changed with breaking changes. "event_type" key was renamed to "object_kind" and "event_name" key is not in all webhook payload. So we now use the request header "X-Gitlab-Event" to distinguish webhook type. Change-Id: I5b30eae01ce716a7d4edcf2d5ba67de07e1fbfc8

+83 −105
Yannis ROSSETTO (rossettoy) 2021-04-22 11:13
Yannis ROSSETTO (rossettoy) 2021-04-22 11:16
12dec88a48bb1c57602d6635d0a2a6a01e385d59
a265d4cc9f9cf684f7d169ff92cdc57f4ec8e6b5
git #tuleap/stable/12dec88a48bb1c57602d6635d0a2a6a01e385d59

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Repository/GitlabRepositoryWebhookController.php +2 −2 Go to diff View file
R plugins/gitlab/include/Repository/Webhook/MissingEventKeysException.php Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookDataExtractor.php +32 −30 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PostMergeRequestWebhookDataBuilderTest.php +7 −7 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookDataBuilderTest.php +2 −3 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookDataExtractorTest.php +40 −63 Go to diff View file