Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Mutualize retrieval and saving of scope association with token|code

Download Browse

The same behavior is replicated multiple times and is going to be needed once more for the refresh tokens. It is time to factorize it. No functionnal change. This is part of story #14542: have OAuth2 flow Change-Id: I1c91a53a0e657c1de372d15ba2341ed843d59b26

+134 −482
Thomas Gerbet (tgerbet) 2020-03-24 14:19
Thomas Gerbet (tgerbet) 2020-03-24 16:02
13cb8feb7748dd4e80b12e355d194a8ff919107f
48f6b9f28203db1492b0f513515204c471ba4691
git #tuleap/stable/13cb8feb7748dd4e80b12e355d194a8ff919107f

Modified Files

Side by side diff
Inline diff
Name
M plugins/oauth2_server/include/AccessToken/OAuth2AccessTokenCreator.php +4 −4 Go to diff View file
M plugins/oauth2_server/include/AccessToken/OAuth2AccessTokenVerifier.php +4 −4 Go to diff View file
M plugins/oauth2_server/include/AccessToken/Scope/OAuth2AccessTokenScopeDAO.php +5 −7 Go to diff View file
D plugins/oauth2_server/include/AccessToken/Scope/OAuth2AccessTokenScopeRetriever.php +0 −68 Go to diff View file
M plugins/oauth2_server/include/Grant/AuthorizationCode/OAuth2AuthorizationCodeCreator.php +4 −4 Go to diff View file
M plugins/oauth2_server/include/Grant/AuthorizationCode/OAuth2AuthorizationCodeVerifier.php +4 −4 Go to diff View file
M plugins/oauth2_server/include/Grant/AuthorizationCode/Scope/OAuth2AuthorizationCodeScopeDAO.php +5 −7 Go to diff View file
D plugins/oauth2_server/include/Grant/AuthorizationCode/Scope/OAuth2AuthorizationCodeScopeSaver.php +0 −53 Go to diff View file
M plugins/oauth2_server/include/RefreshToken/OAuth2RefreshTokenCreator.php +6 −6 Go to diff View file
M plugins/oauth2_server/include/RefreshToken/Scope/OAuth2RefreshTokenScopeDAO.php +3 −2 Go to diff View file
D plugins/oauth2_server/include/RefreshToken/Scope/OAuth2RefreshTokenScopeSaver.php +0 −53 Go to diff View file
A plugins/oauth2_server/include/Scope/OAuth2ScopeIdentifierSaverDAO.php +28 −0 Go to diff View file
A plugins/oauth2_server/include/Scope/OAuth2ScopeIdentifierSearcherDAO.php +32 −0 Go to diff View file
R plugins/oauth2_server/include/Grant/AuthorizationCode/Scope/OAuth2AuthorizationCodeScopeRetriever.php Go to diff View file
R plugins/oauth2_server/include/AccessToken/Scope/OAuth2AccessTokenScopeSaver.php Go to diff View file
M plugins/oauth2_server/include/oauth2_serverPlugin.php +7 −10 Go to diff View file
M plugins/oauth2_server/phpunit/AccessToken/OAuth2AccessTokenCreatorTest.php +5 −5 Go to diff View file
M plugins/oauth2_server/phpunit/AccessToken/OAuth2AccessTokenVerifierTest.php +6 −6 Go to diff View file
D plugins/oauth2_server/phpunit/AccessToken/Scope/OAuth2AccessTokenScopeRetrieverTest.php +0 −98 Go to diff View file
M plugins/oauth2_server/phpunit/Grant/AuthorizationCode/OAuth2AuthorizationCodeCreatorTest.php +5 −5 Go to diff View file
M plugins/oauth2_server/phpunit/Grant/AuthorizationCode/OAuth2AuthorizationCodeVerifierTest.php +5 −5 Go to diff View file
D plugins/oauth2_server/phpunit/Grant/AuthorizationCode/Scope/OAuth2AuthorizationCodeScopeSaverTest.php +0 −65 Go to diff View file
M plugins/oauth2_server/phpunit/RefreshToken/OAuth2RefreshTokenCreatorTest.php +5 −5 Go to diff View file
D plugins/oauth2_server/phpunit/RefreshToken/Scope/OAuth2RefreshTokenScopeSaverTest.php +0 −65 Go to diff View file
R plugins/oauth2_server/phpunit/Grant/AuthorizationCode/Scope/OAuth2AuthorizationCodeScopeRetrieverTest.php Go to diff View file
R plugins/oauth2_server/phpunit/AccessToken/Scope/OAuth2AccessTokenScopeSaverTest.php Go to diff View file
M plugins/oauth2_server/tests/integration/Grant/AuthorizationCode/OAuth2AuthorizationCodeDAOTest.php +6 −6 Go to diff View file