Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #13409: Ensure the workflow rules manager can not loop recursively while processing children triggers

Download Browse

This is an extension of 974112c946a808d58c28c571d01a2e63a254d7c8. This situation is never supposed to happen but the code should defend itself if somehow the situation is encountered. Change-Id: Ie34cda25fc51f50ec7040d2b3f85556af0c8b628

+291 −13
Thomas Gerbet (tgerbet) 2019-05-24 17:02
Thomas Gerbet (tgerbet) 2019-05-27 10:26
14be2145eb62b598ae6c278fe6fd80b326c1cc80
21a800902bb294ea2bde7dff7585cec2facbe704
git #tuleap/stable/14be2145eb62b598ae6c278fe6fd80b326c1cc80

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/ArchiveAndDeleteArtifactTaskBuilder.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/TrackerFactory.class.php +3 −1 Go to diff View file
M plugins/tracker/include/Workflow/Trigger/RulesManager.class.php +21 −3 Go to diff View file
M plugins/tracker/include/Workflow/WorkflowFactory.class.php +3 −1 Go to diff View file
A plugins/tracker/include/Workflow/WorkflowRulesManagerLoopSafeGuard.php +54 −0 Go to diff View file
A plugins/tracker/phpunit/Tracker/Workflow/WorkflowRulesManagerLoopSafeGuardTest.php +106 −0 Go to diff View file
A plugins/tracker/phpunit/Tracker/Workflow/WorkflowRulesManagerTest.php +87 −0 Go to diff View file
M plugins/tracker/tests/workflow/Trigger/RulesManagerTest.php +14 −7 Go to diff View file