part of request #29602 Migrate pullrequest file-diffs to TypeScript During the refactoring process, we ended up with a strange bug regarding line numbers provided by CodeMirror's gutterClick event. As a workaround, we decided to parse the line number contained in the gutter element provided by the event's target. However, It happened that this bug was also impacting the unified diff as well. Sadly, the same workaround cannot be used, as the unified diff's gutters display the same numbers for a group of added line and the opposite group of deleted lines. After a lot of investigation, it appears that since the rendering of file-diff widgets is kind of delayed (we don't rely on angular's $timeout anymore), we have to call widget.changed() in order to tell CodeMirror "Hey, be aware that the widget's height might be different, update the stuff you need". We now systematically call this method each time a widget re-renders, and it works fine as before. How to test: - Both in side-by-side and unified diff modes, and on different types of lines (added, removed, unmoved), click to add a new comment --> Each time the NewInlineCommentForm widget is added at the right place. --> No other functional change expected Change-Id: Icbbaf83c36e65de624212be26c00ba2f0f510053

+78 −35

Author

Thomas Gorka (tgorka) 2022-11-30 11:44

Committer

Thomas Gorka (tgorka) 2022-11-30 13:13

Hash 14ef77e15d6edbc089058b41b17dff016a7ba273

Parent 4d041b51cc3a841b313237883e3714b8f2fde3ce

Reference git #tuleap/stable/14ef77e15d6edbc089058b41b17dff016a7ba273