Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Crash when an OpenID Connect provider has a NULL value as icon or color

Download Browse

It seems at some point it was possible to have NULL for icon or color in the plugin_openidconnectclient_provider table. Now, when you create or update a provider without an icon or color an empty string is set in the DB. Commit cbdecd29f123254da93c97283c15eddb1d710ecc introduced an interface to represent common value hold by a provider configuration and enabled strict typing on the concrete implementations. The interface does not expect null for a color and string and as a result a fatal error is encountered when this case happen. Part of request #12832: Support Azure AD as an OpenID Connect provider Change-Id: Ibc9f9b8771855bc7ff5a9b39829d8b5933494d06

+64 −2
Thomas Gerbet (tgerbet) 2019-12-04 10:24
Thomas Gerbet (tgerbet) 2019-12-04 10:24
151c5623cd458cbf6d9ba583f8cc2faa5b77c7b9
3be36a681b8a819bae5ba0c66e1308cae274c7b6
git #tuleap/stable/151c5623cd458cbf6d9ba583f8cc2faa5b77c7b9

Modified Files

Side by side diff
Inline diff
Name
M plugins/openidconnectclient/db/install.sql +2 −2 Go to diff View file
A plugins/openidconnectclient/db/mysql/2019/201912041000_color_icon_not_null.php +62 −0 Go to diff View file