Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: extract ServiceForProjectCollection

Download Browse

In order to decrease responsibilities of Project.class.php, the retrieval of services is delegated to a dedicated object. Furthermore a bunch of unit tests are added in order to provide a safety net for future refactoring. No functional changes. Part of story #33979: have dedicated Backlog service Change-Id: I5640e2bd2a44695a59a94212e3996c774d87830b

+385 −91
Nicolas Terray (nterray) 2023-09-12 09:07
Nicolas Terray (nterray) 2023-09-15 07:51
17c73b27de9ea4b1e6a21aba0cfff36cd20f2784
496a151e2ac038ac89ccb7e1807ada2c7b143d15
git #tuleap/stable/17c73b27de9ea4b1e6a21aba0cfff36cd20f2784

Modified Files

Side by side diff
Inline diff
Name
M src/common/FRS/LicenseAgreement/Admin/LicenseAgreementControllersHelper.php +2 −2 Go to diff View file
M src/common/Project/Project.class.php +19 −83 Go to diff View file
A src/common/Project/Service/ListOfAllowedServicesForProjectRetriever.php +34 −0 Go to diff View file
A src/common/Project/Service/ServiceForProjectCollection.php +136 −0 Go to diff View file
M src/common/Project/ServiceManager.class.php +3 −2 Go to diff View file
M tests/unit/common/FRS/LicenseAgreement/Admin/EditLicenseAgreementControllerTest.php +1 −1 Go to diff View file
M tests/unit/common/FRS/LicenseAgreement/Admin/LicenseAgreementControllersHelperTest.php +2 −2 Go to diff View file
M tests/unit/common/FRS/LicenseAgreement/Admin/SaveLicenseAgreementControllerTest.php +1 −1 Go to diff View file
A tests/unit/common/Project/Service/ServiceForProjectCollectionTest.php +139 −0 Go to diff View file
A tests/unit/tests/Stubs/Project/Service/ListOfAllowedServicesForProjectRetrieverStub.php +48 −0 Go to diff View file