stable

Clone or download

Read-only

Transform the artifact modal into a lib

Part of request #20062 Transform the artifact modal into a lib How to test: Run end-to-end tests for agiledashboard and testmanagement. No functional change expected. Notes: The artifact modal is now an internal lib. The two PNG images included are now inlined as base64. All webpack configuration, npm modules, mocks and env variables previously needed to build the artifact modal should have been removed from TTM and AD plugins. It is bundled with webpack because I could not make it work with vite, this can be done at a later contribution. Change-Id: Ic9a6bce5b0ec131e56c0f16244f0585f9df0ffb8

Modified Files

Name
M plugins/agiledashboard/package-lock.json +0 −24 Go to diff View file
M plugins/agiledashboard/package.json +2 −4 Go to diff View file
A plugins/agiledashboard/scripts/kanban/__mocks__/@tuleap/plugin-tracker-artifact-modal.js +29 −0 Go to diff View file
M plugins/agiledashboard/scripts/kanban/jest.config.js +1 −6 Go to diff View file
M plugins/agiledashboard/scripts/kanban/package.json +1 −0 Go to diff View file
M plugins/agiledashboard/scripts/kanban/src/app/app.js +1 −1 Go to diff View file
A plugins/agiledashboard/scripts/planning-v2/__mocks__/@tuleap/plugin-tracker-artifact-modal.js +29 −0 Go to diff View file
M plugins/agiledashboard/scripts/planning-v2/jest.config.js +1 −1 Go to diff View file
M plugins/agiledashboard/scripts/planning-v2/package.json +1 −0 Go to diff View file
M plugins/agiledashboard/scripts/planning-v2/src/app/app.js +2 −2 Go to diff View file
M plugins/agiledashboard/themes/BurningParrot/css/_kanban.scss +1 −1 Go to diff View file
M plugins/agiledashboard/themes/BurningParrot/css/scrum/_planning.scss +1 −1 Go to diff View file
M plugins/agiledashboard/webpack.common.js +2 −29 Go to diff View file
M plugins/testmanagement/jest.config.js +1 −5 Go to diff View file
M plugins/testmanagement/package-lock.json +0 −24 Go to diff View file
M plugins/testmanagement/package.json +2 −3 Go to diff View file
A plugins/testmanagement/scripts/testmanagement/src/__mocks__/@tuleap/plugin-tracker-artifact-modal.js +29 −0 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/app.js +1 −1 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution/execution.js +1 −1 Go to diff View file
M plugins/testmanagement/themes/BurningParrot/css/_testmanagement.scss +1 −1 Go to diff View file
M plugins/testmanagement/webpack.common.js +1 −14 Go to diff View file
M plugins/tracker/build-manifest.json +2 −2 Go to diff View file
M plugins/tracker/package.json +1 −1 Go to diff View file
D plugins/tracker/scripts/angular-artifact-modal/README.mkd +0 −51 Go to diff View file
D plugins/tracker/scripts/angular-artifact-modal/_index.scss +0 −1 Go to diff View file
D plugins/tracker/scripts/angular-artifact-modal/index.js +0 −1 Go to diff View file
D plugins/tracker/scripts/angular-artifact-modal/package.json +0 −46 Go to diff View file
D plugins/tracker/scripts/angular-artifact-modal/src/quota-display/_quota-display.scss +0 −31 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/.gitignore +1 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/README.md +73 −0 Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/jest.config.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/package-lock.json Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/package.json +54 −0 Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/po/fr_FR.po Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/__mocks__/@tuleap/angular-tlp.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/__mocks__/@tuleap/plugin-tracker-rich-text-editor.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/__mocks__/jquery.js Go to diff View file
R plugins/agiledashboard/scripts/planning-v2/__mocks__/ckeditor4.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/api/tuleap-api.test.ts Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/api/tuleap-api.ts Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/artifact-edition-initializer.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/assets/artifact_attachment_default.png Binary file Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/assets/image_example_commonmark.png Binary file Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/CommonmarkPreviewButton.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/CommonmarkPreviewButton.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/CommonmarkSyntaxHelper.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/CommonmarkSyntaxHelper.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/FormatSelector.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/FormatSelector.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/RichTextEditor.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/RichTextEditor.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/textfield-mixin.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/common/textfield-mixin.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/field-dependencies-helper.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/field-dependencies-helper.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/_computed-field.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field-value-formatter.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field-value-formatter.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/computed-field/computed-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/date-field/date-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/date-field/date-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/date-field/date-field-initializer.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/date-field/date-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/disabled-field-detector.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/disabled-field-detector.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/_file-field.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/base64-transform.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-detector.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-detector.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-validator.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-validator.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-input-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-rules-state.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-rules-state.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-uploader.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/is-uploading-in-ckeditor-state.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/streaming-file-reader.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-initializer.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-value-formatter.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field-value-formatter.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/link-field/link-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-field/list-picker-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-field/list-picker-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-field/list-picker-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-multiple-field/list-picker-mulitple-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-multiple-field/list-picker-multiple-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/list-picker-multiple-field/list-picker-multiple-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/_open-list-field.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/open-list-field-ids-initializer.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/open-list-field-initializer.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/open-list-field-validate-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/open-list-field-validate-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/static-open-list-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/static-open-list-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/static-open-list-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/static-open-list-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/ugroups-open-list-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/ugroups-open-list-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/ugroups-open-list-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/ugroups-open-list-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/users-open-list-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/users-open-list-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/users-open-list-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/users-open-list-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/open-list-field/users-result-template.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field-value-formatter.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field-value-formatter.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/permission-field/permission-field.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/TextField.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/TextField.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field-value-formatter.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field-value-formatter.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/followups/FollowupEditor.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/followups/FollowupEditor.vue Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/gettext-catalog.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/helpers/local-vue.js Go to diff View file
R plugins/agiledashboard/scripts/kanban/__mocks__/ckeditor4.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/modal-creation-mode-state.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/UserPreferencesStore.ts Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/awkward-creation-fields-constant.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/field-values-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/field-values-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/form-tree-builder.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/form-tree-builder.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/tracker-transformer-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/tracker-transformer-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/workflow-field-values-filter.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/model/workflow-field-values-filter.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/ng-vue-config.js Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/quota-display/_quota-display.scss +50 −0 Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/quota-display/quota-display-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/quota-display/quota-display-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/quota-display/quota-display.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/rest/rest-error-state.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/rest/rest-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/rest/rest-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/store/getters.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/store/index.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/store/mutations.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/store/state.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-controller.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-controller.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal.tpl.html Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-focus/focus-on-click-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-highlight/_highlight.scss Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-highlight/highlight-directive.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/tuleap-highlight/highlight-directive.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/validate-artifact-field-value.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/validate-artifact-field-value.test.js Go to diff View file
R plugins/tracker/scripts/angular-artifact-modal/src/vuex-store.js Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tsconfig.json +12 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/webpack.common.js +75 −0 Go to diff View file
R plugins/agiledashboard/scripts/kanban/tests/ckeditor-image-upload-mock.js Go to diff View file
R plugins/testmanagement/scripts/testmanagement/tests/ckeditor-image-upload-mock.js Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/README.md +2 −0 Go to diff View file
M src/themes/tlp/src/scss/components/_css-var-root.scss +1 −0 Go to diff View file
M tools/utils/scripts/vite-configurator.ts +1 −3 Go to diff View file