Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacor: compute is_milestone in Task

Download Browse

Instead of duplicating the algorithm to detect if a task is a milestone or not, we now compute the information earlier, as soon as the task is retrieve from the API. It will be easier later if we need to move this information backend side. No functional change in the display of milestones. Part of story #20979: Display children in Roadmap Change-Id: Ic2e84e1cb6cfa3cc841a46cfe1638eed0877ee76

+125 −57
Nicolas Terray (nterray) 2021-05-04 08:10
Nicolas Terray (nterray) 2021-05-04 08:10
19b54cfe259b333a17947f7dc57b206a9cbcbd65
159e7f72d827c09e9e542284262454bd3c757ce3
git #tuleap/stable/19b54cfe259b333a17947f7dc57b206a9cbcbd65

Modified Files

Side by side diff
Inline diff
Name
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/BarPopover.test.ts +28 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/BarPopover.vue +1 −9 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/GanttTask.test.ts +8 −23 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/GanttTask.vue +2 −11 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/TaskBar.test.ts +8 −8 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/TaskBar.vue +1 −4 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/components/Gantt/Task/TaskHeader.test.ts +1 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/helpers/task-retriever.test.ts +72 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/helpers/task-retriever.ts +1 −0 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/store/tasks/tasks-actions.test.ts +2 −2 Go to diff View file
M plugins/roadmap/scripts/roadmap-widget/src/type.ts +1 −0 Go to diff View file