Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Correct import xml display error

Download Browse

part of story #14291 Beautiful tracker creation Intorduced by: Id3404aa9ea077356d5a23eab24af466396c615d8 I've done a mistake in TrackerManager: XML_ParseException && TrackerFromXmlException have been forgotten to be moved into createTrackerFromXml Let's introduce it again, the method displayCreateTrackerFromXMLErrors have been moved into a dedicated object (it will be removed by gerrit #17884 so let's reintroduce it clean into its own object). How to test: - have an incorrect xml, in legacy UI create a tracker => xml validation error, is properly displayed - submit form without xml file => error is properly displayed - create a tracker with an invalid name (already existing in project as an example) => error is porperly displayed You should be abled to cretae a new tracker as usual, if xml is valid Change-Id: I5bd4ddfc56e880e12f7d8cc812e4a7c917e0f808

+332 −18
Marie Ange Garnier (marieange) 2020-02-24 16:27
Marie Ange Garnier (marieange) 2020-02-25 12:16
1aca0c69f5221b44292128ba190cae8cbb942697
d138354cf0ca4414869f4c627f945202005dcb11
git #tuleap/stable/1aca0c69f5221b44292128ba190cae8cbb942697

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Creation/TrackerCreator.php +39 −8 Go to diff View file
A plugins/tracker/include/Tracker/Creation/TrackerCreatorXmlErrorDisplayer.php +150 −0 Go to diff View file
M plugins/tracker/include/Tracker/TrackerManager.class.php +2 −3 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +1 −4 Go to diff View file
M plugins/tracker/phpunit/Tracker/Creation/TrackerCreatorTest.php +9 −3 Go to diff View file
A plugins/tracker/phpunit/Tracker/Creation/TrackerCreatorXmlErrorDisplayerTest.php +131 −0 Go to diff View file