Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Custom session should not rely on a PHP warning

Download Browse

This warning is now replaced by an explicit exception. With PHP 8.0 this warning is now a \TypeError so it cannot be considered as inconsequential anymore [0]. It does not look like the warning is triggered on production, at least it does not appears in the logs of Tuleap servers Enalean manages directly. In any case it should be considered as a bug since it indicates somethin unexpected happen in the code. The test should now pass with PHP 8.0: make tests-unit-php PHP_VERSION=80 FILES=tests/unit/common/session/Codendi_SessionTest.php Part of request #17931: Unit tests should pass with PHP 8.0 [0] https://github.com/php/php-src/blob/php-8.0.0/UPGRADING#L113-L114 Change-Id: Ifcab130f6613d7a7f756309f0e7f8db18213382a

+47 −7
Thomas Gerbet (tgerbet) 2020-12-14 17:02
Thomas Gerbet (tgerbet) 2020-12-14 17:02
1b8bcd6ec2831058d4c1880345b4ef1b71bf403a
eee1b5c9c8ce0e59ee871a954eabb25714f1968d
git #tuleap/stable/1b8bcd6ec2831058d4c1880345b4ef1b71bf403a

Modified Files

Side by side diff
Inline diff
Name
M src/common/session/Codendi_Session.class.php +8 −4 Go to diff View file
A src/common/session/IncorrectSessionNamespaceException.php +35 −0 Go to diff View file
M tests/unit/common/session/Codendi_SessionTest.php +4 −3 Go to diff View file