stable

Clone or download

Read-only

refactor: remove second deprecated call to Artifact::createNewChangeset

part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: - when there is a Done or a Closed value, the Artifact is closed with a comment. - when there is no Done or Closed value, or there is no Status field, a comment is added on the artifact to explain the problem. Notes: This also replaces the string parameter by an interface called ArtifactClosingCommentInCommonMarkFormat. It is stricter than allowing any string to be passed. Change-Id: I949ac1d4ab8feab24ca78134642a19b85a2e60d1

Modified Files

Name
A plugins/gitlab/include/Repository/Webhook/PostPush/ArtifactClosingCommentInCommonMarkFormat.php +33 −0 Go to diff View file
R plugins/gitlab/include/Repository/Webhook/PostPush/PostPushTuleapArtifactCommentBuilder.php Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushCommitArtifactUpdater.php +45 −27 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandler.php +1 −1 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +72 −74 Go to diff View file
R plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushTuleapArtifactCommentBuilderTest.php Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitArtifactUpdaterTest.php +63 −39 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandlerTest.php +22 −17 Go to diff View file
A plugins/gitlab/tests/unit/Test/Stub/ArtifactClosingCommentInCommonMarkFormatStub.php +43 −0 Go to diff View file
M plugins/tracker/tests/unit/Stub/CreateNewChangesetStub.php +9 −0 Go to diff View file