Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: ensure uniqueness of id

Download Browse

In html, id attribute must be unique in a given DOM document. Until now, we were using the id of the artifact. Using a number does not guarantee that the id will be unique. Other element in the page might have a similar id. Decreasing the chance to have similar id is done by prefixing the id with "section-" (we are targeting a section after all) and by using the section uuid instead of the artifact. We don't know yet if there will be other type of section than artifact (e.g.: freetext) so using the artifact id is not really safe. We can still navigate in the document via the table of contents. This eventually breaks links that might have been bookmarked by early birds. Not really part of story #38630: Export to file Change-Id: Ic2c223a5b3318b5a60d110a625c155f5a363a0da

+32 −28
Nicolas Terray (nterray) 2024-07-16 13:16
Nicolas Terray (nterray) 2024-07-16 13:16
1bf2142545df3d34b4be358c1abeab423de8a627
ebaebd9fdc3b10c025e19a6d3a227ec3f1465d7b
git #tuleap/stable/1bf2142545df3d34b4be358c1abeab423de8a627

Modified Files

Side by side diff
Inline diff
Name
M plugins/artidoc/scripts/artidoc/src/components/DocumentContent.test.ts +19 −14 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/DocumentContent.vue +1 −2 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/toc/TableOfContents.test.ts +11 −10 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/toc/TableOfContents.vue +1 −2 Go to diff View file