stable

Clone or download

Read-only

refactor: Handle faults with events

No functional change. All errors from the following situations are shown in the modal feedback section: - loading the parent (for example when you create a task child of a user story in planning view) - loading the existing links - loading the link types - loading the user history when autocompleting in artifact links - loading an artifact by its ID when autocompleting - loading possible parents when autocompleting - searching an artifact (fulltext) when autocompleting - loading follow-up comments Notes: Using events lets us reuse the DispatchEvent interface. It means fewer dependencies for big controllers. Functionally, it keeps working the same way. part of request #22648 Convert AngularJS directives and controllers to hybrids web components Change-Id: Ief8360fe5385456dd3af57e494eb60de0a8a2c7d

Modified Files

Name
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.test.ts +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.test.ts +14 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.ts +13 −15 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ParentFeedbackController.test.ts +7 −7 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ParentFeedbackController.ts +5 −4 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.test.ts +10 −29 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.ts +7 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.test.ts +3 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.test.ts +3 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/TypeSelectorTemplate.test.ts +3 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/dropdown/ArtifactLinkSelectorAutoCompleter.test.ts +11 −12 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/dropdown/ArtifactLinkSelectorAutoCompleter.ts +9 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DomainEvent.ts +5 −1 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/ClearFaultNotification.ts Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/NotifyFault.ts Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.test.ts +5 −5 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.ts +4 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +5 −7 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ClearFaultNotificationStub.ts +0 −36 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/tests/stubs/DispatchEventsStub.ts +17 −8 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/tests/stubs/NotifyFaultStub.ts +0 −36 Go to diff View file