No functional change expected. Having those methods mutation-free was originally needed so that we could use @template-covariant. It is far too restricting to have those methods mutation-free (as it means we can only call other mutation-free functions). It sort of defeats the purpose of Ok|Err, as pure functions cannot really fail or at least not in the way that database queries and HTTP calls can fail. Since all methods are not mutation-free, we cannot use @template-covariant anymore, so there is no reason to keep those methods mutation-free. We should relax the constraint on map() and mapErr() too as it makes them way too hard to use. Change-Id: I2a9cc1fba8a6127db0d6b97db5ef81e58990b4b6

+4 −6

Author

Joris MASSON (jmasson) 2022-07-21 18:23

Committer

Joris MASSON (jmasson) 2022-07-22 09:15

Hash 1d6e924d7e9ecb1874bdf2757e1f44940a193e85

Parent 137e875aa5c9f0be814197b57a1be319b9038c05

Reference git #tuleap/stable/1d6e924d7e9ecb1874bdf2757e1f44940a193e85