Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Move Interface before FormatSelectorBuilder

Download Browse

Part of story #18336 add support of markdown No functional change expected in Artifact view when adding a new follow-up comment. Notes: FormatSelectorBuilder is also part of the "Display for FlamingParrot domain". We should isolate our domain (RichTextEditor) from it. If we were to change that code and use lit-html or mustache or some other rendering library, we would not manipulate HTMLOptionElements and HTMLDivElements. Letting the interface insert the Format selector also leaves us the possibility of a "no-op" interface for cases where the Format selectbox is created another way. Change-Id: I7415dc7ecf556158167a537bde8167eba7c6f355

+63 −41
Joris MASSON (jmasson) 2021-02-02 12:38
Joris MASSON (jmasson) 2021-02-02 15:21
20df10f0b5d30e26f8ad8a66b120e56996822cb2
701ab609b72abc33032becb89086819fa642195e
git #tuleap/stable/20df10f0b5d30e26f8ad8a66b120e56996822cb2

Modified Files

Side by side diff
Inline diff
Name
R plugins/tracker/scripts/lib/rich-text-editor/src/DocumentInterface.ts Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/FlamingParrotDocumentAdapter.test.ts +1 −2 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/FlamingParrotDocumentAdapter.ts +21 −7 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/FormatSelectorBuilder.test.ts +24 −10 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/FormatSelectorBuilder.ts +11 −14 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/RichTextEditorFactory.ts +6 −8 Go to diff View file