stable
Clone or download
Read-only
request #12065 Infinite loop when a user cannot see a campaign
How to test: - build the app - Add a Permission field on the Campaign tracker. Set up a campaign artifact so that a user cannot read it - As that user, browse the campaign list - Without this patch, an inifinite loop happens and the spinner is always shown. With it, the list (without the one the user can't see) will display. - I took the opportunity to add feedback to the user when there is a problem in a query Will be done later: - All closed campaigns are still loaded (see request #11209). This will be a dedicated patch. Change-Id: Id04ae924ce877897b00e74f4c24a6337dd40e216
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | www/scripts/angular/po/fr.po | +13 | −1 | Go to diff View file |
| M | www/scripts/angular/po/template.pot | +4 | −0 | Go to diff View file |
| A | www/scripts/angular/src/app/api/rest-querier.js | +34 | −0 | Go to diff View file |
| A | www/scripts/angular/src/app/api/rest-querier.spec.js | +57 | −0 | Go to diff View file |
| M | www/scripts/angular/src/app/app.spec.js | +17 | −15 | Go to diff View file |
| M | www/scripts/angular/src/app/campaign/campaign-list-controller.js | +75 | −53 | Go to diff View file |
| A | www/scripts/angular/src/app/campaign/campaign-list-controller.spec.js | +212 | −0 | Go to diff View file |
| M | www/scripts/angular/src/app/campaign/campaign-list.tpl.html | +1 | −0 | Go to diff View file |
| M | www/scripts/angular/src/app/campaign/campaign-service.js | +0 | −22 | Go to diff View file |
| M | www/scripts/angular/src/app/campaign/campaign-service.spec.js | +0 | −26 | Go to diff View file |
| M | www/scripts/angular/src/app/campaign/campaign.js | +5 | −1 | Go to diff View file |
| M | www/themes/BurningParrot/css/includes/_campaign.scss | +0 | −4 | Go to diff View file |
| M | www/themes/BurningParrot/css/includes/_execution.scss | +0 | −4 | Go to diff View file |