Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Do not mix list binds with open list test builder

Download Browse

Implement request #37556 Do not mix list binds with open list test builder No functional change. CI should be happy. Why? Mixing parameters meant for two different constructors should be avoided. It makes the open list builder too dependent upon the list binds. We can follow the same approach as the other list fields: first build a field, and then pass it as parameter to the list bind builder. It follows how things work for the real production code. Follow-up to git #tuleap/stable/6bac1b569739441da9ba0406ba9274399fa42c2 Change-Id: I76742e5a450d2e9219315fd8fdfb760d852c6753

+73 −145
Joris MASSON (jmasson) 2024-04-04 17:58
Joris MASSON (jmasson) 2024-04-05 12:13
21a0db80e5b10b53906cd8682f5d37dcac085e28
ee85c74d96aa10c0564bf68a2f00418c94de76b7
git #tuleap/stable/21a0db80e5b10b53906cd8682f5d37dcac085e28

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +12 −10 Go to diff View file
M plugins/tracker/tests/unit/Builders/Fields/OpenListFieldBuilder.php +23 −119 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/OpenListFieldVerifierTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/UserGroupOpenListFieldVerifierTest.php +8 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +2 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/XML/Updater/MoveChangesetXMLDuckTypingUpdaterTest.php +19 −7 Go to diff View file
M plugins/tracker/tests/unit/Tracker/XML/Updater/OpenListUserGroupsByDuckTypingUpdaterTest.php +7 −2 Go to diff View file