stable

Clone or download

Read-only

story #8399: rejects insecure mail when token based

This commits includes small bug fixes: - do not accept insecure mail when the platform accepts only token based mails. - do not display reply-by-mail help when tracker does not activate the mail gateway. This involved a refactoring therefore this review looks like quite big but it's not. The impacts are both at display level (display of icons/helps) and at reception level. Change-Id: I087849267f7cacf8c7accecb31934b92b70af2a1

Modified Files

Name
M plugins/tracker/bin/emailgateway.php +6 −5 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/MailGateway/IncomingMessageInsecureBuilder.class.php +1 −1 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/MailGateway/InsecureMailGateway.php +30 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/MailGateway/MailGateway.class.php +48 −28 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/MailGateway/MailGatewayBuilder.php +114 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/MailGateway/Notifier.class.php +8 −4 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/MailGateway/TokenMailGateway.php +30 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact.class.php +20 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Changeset.class.php +20 −18 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/View/Edit.class.php +3 −13 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/Tracker_ArtifactByEmailStatus.class.php +31 −23 Go to diff View file
M plugins/tracker/include/autoload.php +5 −2 Go to diff View file
A plugins/tracker/tests/Tracker/Artifact/MailGateway/MailGatewayBuilderTest.php +70 −0 Go to diff View file
M plugins/tracker/tests/Tracker/Artifact/MailGateway/MailGatewayTest.php +145 −29 Go to diff View file
A plugins/tracker/tests/Tracker/Artifact/MailGateway/_fixtures/insecure-reply-comment.plain.eml +73 −0 Go to diff View file
M plugins/tracker/tests/Tracker_ArtifactByEmailStatusTest.php +88 −35 Go to diff View file