How to test: - No functional change in the REST API POST /artifacts. You can still set reverse links through the "all_links" key. Notes: - Having a distinct Command object for the "Creation" case is better, because it's impossible to change the type or delete a reverse link to an artifact that does not yet exist. When creating an artifact, you can only add new reverse links. Having distinct objects should help us avoid mixing those cases. - Introducing an intermediary "converter" objects that builds changesets from Command objects has several advantages. It isolates the logic of "flipping" reverse links to forward links in the "domain" of trackers, where we only deal with business objects. It also lets us unit-test its output in details: it is easier to assert directly on NewChangeset objects than to have a stub and ask it for its last parameters. This intermediary will also be reused in the "update" case and will completely replace ArtifactUpdateHandler. - FieldsDataBuilder stubs are completely removed. As they do not deal with DB directly, we should use the real objects and stub their dependencies (which are few). This lets us do a "sociable" test: in ArtifactCreatorTest, we can give it an array of Representation objects, mock only the DB accesses (for fields, artifacts) and assert that we created the expected reverse link changesets. part of request #34374 Be able to explicitly add, change or remove forward and reverse links Change-Id: Ib3ac0f4c5c92c6d9f92b6a3ef4da0a1d4b3dafbc

+653 −298

Author

Joris MASSON (jmasson) 2023-10-03 09:52

Committer

Joris MASSON (jmasson) 2023-10-04 11:57

Hash 2322183260f814f58b9f5743d5399addc99a5296

Parent 2ef692e76df902b2e6623ae3054177c4bb13bd07

Reference git #tuleap/stable/2322183260f814f58b9f5743d5399addc99a5296