The aim of this contribution is to better segregate Visitable implementations. Currently we have the following inheritance: Visitable ├ AndExpression ├ AndOperand ├ OrExpression ├ OrExpression ├ Comparison │ ├ BetweenComparison │ ├ GreaterThanOrEqualComparison │ ├ NotEqualComparison │ ├ LesserThanOrEqualComparison │ ├ NotInComparison │ ├ InComparison │ ├ LesserThanComparison │ ├ GreaterThanComparison │ └ EqualComparison └ Searchable ├ Metadata └ Field This contribution introduces the `Logical` interface so that we now have: Visitable ├ Logical │ ├ AndExpression │ ├ AndOperand │ ├ OrExpression │ └ OrExpression ├ Comparison │ ├ BetweenComparison │ ├ GreaterThanOrEqualComparison │ ├ NotEqualComparison │ ├ LesserThanOrEqualComparison │ ├ NotInComparison │ ├ InComparison │ ├ LesserThanComparison │ ├ GreaterThanComparison │ └ EqualComparison └ Searchable ├ Metadata └ Field Note: since we now have return types on getExpression/getOperand, psalm is not happy about Term not having `accept` method (In QueryBuilderVisitor for example). So now Term extends Visitable. No functional changes Preparation step for epic #32276: Filter on Artifact Links with TQL Change-Id: I85f1fb96a21d2bc41c2b8b13efbd3d68c23b35f4

+43 −61

Author

Nicolas Terray (nterray) 2023-05-29 12:03

Committer

Nicolas Terray (nterray) 2023-05-29 17:13

Hash 232c4ad48ee1b9c0dc60a5b1696c496fc3f535af

Parent 573027ac0ef516dd9132d4f7b6cde5b255420011

Reference git #tuleap/stable/232c4ad48ee1b9c0dc60a5b1696c496fc3f535af