Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: TypeScript errors in Tuleap core

Download Browse

part of request #28863 fix TypeScript Jest coverage No functional change. If you "cd" in src/ and run the following command, it should succeed without an error ELIFECYCLE. $ COLLECT_COVERAGE=true CI=true pnpm run test --runInBand Notes: When Jest does the typechecking (as is the case in Git plugin and Core), it should now print typescript errors instead of just silently failing the test. Since "switch-to" has its own build/test scripts, it collects its own coverage. Mixing with the rest of "core" breaks things as the different Vue versions conflict with each other. Other changes were TypeScript errors. We should avoid pulling anything from "www/" folder. The same CKEditor config has been written in typescript, but the one from "www/" folder is still used by legacy scripts that don't use a bundler like webpack or vite, so we can't remove it just yet. Change-Id: I39e5a0ca3d292f3ed36c0ba669e640a85527ac46

+39 −64
Joris MASSON (jmasson) 2022-09-26 15:10
Joris MASSON (jmasson) 2022-09-26 15:54
235c03012224ab67fecdc1fe561a87bc35c075e6
3fab37690361d4319ea6ec69a67084037784cbf9
git #tuleap/stable/235c03012224ab67fecdc1fe561a87bc35c075e6

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/build-system-configurator/src/jest/base-config.ts +5 −2 Go to diff View file
M src/jest.config.js +1 −0 Go to diff View file
R src/scripts/frs/admin/ckeditor4.d.ts Go to diff View file
D src/scripts/dashboards/widgets/ckeditor4.d.ts +0 −22 Go to diff View file
M src/scripts/dashboards/widgets/contact-modal.ts +2 −2 Go to diff View file
M src/scripts/frs/admin/license-agreement.ts +2 −2 Go to diff View file
D src/scripts/site-admin/ckeditor4.d.ts +0 −22 Go to diff View file
M src/scripts/site-admin/massmail.ts +4 −1 Go to diff View file
M src/scripts/site-admin/password-policy.ts +2 −0 Go to diff View file
M src/scripts/site-admin/system-events-admin-homepage.ts +3 −0 Go to diff View file
M src/scripts/tuleap/tuleap-ckeditor-config.ts +3 −3 Go to diff View file
M src/tsconfig.json +16 −9 Go to diff View file
M src/www/scripts/tuleap/tuleap-ckeditor-toolbar.d.ts +1 −1 Go to diff View file