stable
Clone or download
Existing check that was done in pre.php is now transfered in a dedicated sanity-check command with the more strict check of MySQL version and sql modes. The move to dedicated command allows to de-clutter pre.php and to be more strict on checks because it's easier not to run `sanity-check` command when we want to run tests with configuration not already supported in production. The tuleap.service unit is also modified to ensure all commands are run. Because --clear-caches and --restore-caches are not really options but commands named "--something", it's not actually possible to run: tuleap --clear-caches --restore-caches Only the former command is actually ran. Finally, checks are aligned between Docker and RPM install. BREAKING CHANGE: Tuleap running with improper SQL modes will refuse to start. Same for Tuleap running on unsupported databases (eg MariaDB). There are possibilies to workaround and let it start. It's mainly intended for test purposes (eg test future version of MySQL): * `setup:mysql-init` has `--skip-sanity-check` (for install) * `tuleap.service` can be overriden with `systemctl edit` and remove the sanity check * Docker installation can use `SKIP_SANITY_CHECK=1` Part of request #39367 Tuleap should have strict check of database Change-Id: I8b9c227bc97cdf85033772e19a6fdb39092ef5e0
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tee_container/docker/compose.yaml | +2 | −0 | Go to diff View file |
| A | src/common/CLI/Command/SanityCheckCommand.php | +67 | −0 | Go to diff View file |
| M | src/tuleap-cfg/Command/Docker/Tuleap.php | +56 | −10 | Go to diff View file |
| M | src/tuleap-cfg/Command/Docker/VariableProviderFromEnvironment.php | +11 | −0 | Go to diff View file |
| M | src/tuleap-cfg/Command/Docker/VariableProviderInterface.php | +7 | −0 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/ConnectionManager.php | +25 | −2 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/ConnectionManagerInterface.php | +7 | −1 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/DatabaseConfigurator.php | +35 | −3 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysqlInitCommand.php | +16 | −17 | Go to diff View file |
| M | src/tuleap-cfg/tuleap-cfg.php | +0 | −1 | Go to diff View file |
| M | src/utils/systemd/tuleap-php-fpm.service | +2 | −0 | Go to diff View file |
| M | src/utils/systemd/tuleap-worker@.service | +2 | −0 | Go to diff View file |
| M | src/utils/systemd/tuleap.service | +3 | −1 | Go to diff View file |
| M | src/utils/tuleap.php | +5 | −0 | Go to diff View file |
| M | src/www/include/pre.php | +0 | −13 | Go to diff View file |
| M | tests/integration/bin/setup.sh | +2 | −1 | Go to diff View file |
| M | tests/unit/tuleap-cfg/Command/Docker/PluginsInstallClosureBuilderFromVariableTest.php | +11 | −0 | Go to diff View file |
| M | tests/unit/tuleap-cfg/Command/SetupMysqlInitCommandAzureTest.php | +1 | −3 | Go to diff View file |
| M | tests/unit/tuleap-cfg/Command/SetupMysqlInitCommandTest.php | +1 | −3 | Go to diff View file |
| M | tests/unit/tuleap-cfg/Command/TestConnectionManager.php | +5 | −1 | Go to diff View file |