stable

Clone or download

Read-only

refacto: Use CrossTrackerReportDao::searchCrossTrackerWidgetByCrossTrackerReportId

Part of story #39330 Choose on which tracker I perform my query In a previous I've added a method to ProjectDasboardDao to retrieve project id from the widget_content_id and widget_type. But there was already an existing one in CrossTrackerReportDao. This commit fix this duplication by using the existing method and removing 🔥 the one from ProjectDashboardDao (not used anymore) *No functional changes expected* Change-Id: If72b0e4b688022c131355c43c963af1e82e0c58c

Modified Files

Name
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +7 −24 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/FromBuilder/FromProjectBuilderVisitor.php +8 −8 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/FromBuilder/FromTrackerBuilderVisitor.php +5 −7 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidFromProjectCollectorVisitor.php +5 −6 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/WidgetInProjectChecker.php +5 −4 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/ReportTrackersRetriever.php +3 −3 Go to diff View file
M plugins/crosstracker/include/crosstrackerPlugin.php +5 −23 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/CrossTrackerFieldTestCase.php +5 −0 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php +7 −24 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidFromCollectionBuilderTest.php +29 −29 Go to diff View file
D src/common/Dashboard/Project/IRetrieveProjectFromWidget.php +0 −28 Go to diff View file
M src/common/Dashboard/Project/ProjectDashboardDao.php +1 −16 Go to diff View file
M tests/integration/bin/setup.sh +2 −1 Go to diff View file
M tests/integration/tests/Dashboard/Project/ProjectDashboardDaoTest.php +0 −22 Go to diff View file
D tests/lib/Stubs/Dashboard/Project/IRetrieveProjectFromWidgetStub.php +0 −48 Go to diff View file