stable
Clone or download
part of story #31069 Render everything that is read only This contributions aims to display any error occurring during the loading of data, like the pull-request or author info. Since we don't have any mockups regarding the way we should display those errors, I decided to recreate the same modal as the one we have in the angular app. We'll see later with UXD how things should be done, when he'll be available. How to test: - throw a RestException in PullRequestResource line 347 --> The modal opens - Move the RestException to UserResource line 123 --> The modal opens In the modal: - The details are shown when you click [show details] - The modal is closed when you click [OK] in the footer. Note: We might want to redirect the user somewhere else, but it is the current behavior in pullrequest-app, so I guess it is goodenough for now. Change-Id: I63f849ecffd18869a378fc12b80705930de89a79
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequest-overview/package.json | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/pnpm-lock.yaml | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/po/fr_FR.po | +18 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Modals/PullRequestErrorModal.test.ts | +81 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Modals/PullRequestErrorModal.vue | +104 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewPane.vue | +14 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/ReadOnlyInfo/PullRequestAuthor.test.ts | +36 | −10 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/ReadOnlyInfo/PullRequestAuthor.vue | +7 | −2 | Go to diff View file |