stable

Clone or download

Read-only

request #14719: Replace inline docblock declarations with assertions

Assertions present the advantage they can be verified at runtime in test environments while having no cost in production environments. Change-Id: If4068ef8bf4ccde7ec32e6fb85aa850c8149b1cc

Modified Files

Name
M plugins/agiledashboard/include/agiledashboardPlugin.php +1 −1 Go to diff View file
M plugins/artifactsfolders/include/Folder/ArtifactLinkInformationPrepender.php +1 −1 Go to diff View file
M plugins/artifactsfolders/include/Folder/FolderHierarchicalRepresentationCollectionBuilder.php +1 −1 Go to diff View file
M plugins/artifactsfolders/include/Folder/HierarchyOfFolderBuilder.php +1 −1 Go to diff View file
M plugins/bugzilla_reference/include/bugzilla_referencePlugin.php +3 −3 Go to diff View file
M plugins/captcha/include/captchaPlugin.php +1 −1 Go to diff View file
M plugins/cardwall/include/Cardwall/AccentColor/AccentColorBuilder.php +1 −1 Go to diff View file
M plugins/cardwall/include/cardwallPlugin.php +1 −1 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Permission/CrossTrackerPermissionGate.php +3 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/CSV/Format/FormElementToValueVisitor.php +2 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/CSV/SimilarFieldsFormatter.php +1 −1 Go to diff View file
M plugins/docman/include/Docman_Actions.class.php +1 −3 Go to diff View file
M plugins/docman/include/REST/v1/DocmanEmptyDocumentsResource.php +2 −2 Go to diff View file
M plugins/docman/include/REST/v1/DocumentBeforeVersionCreationValidatorVisitor.php +1 −3 Go to diff View file
M plugins/docman/include/REST/v1/Metadata/CustomMetadataCollectionBuilder.php +2 −6 Go to diff View file
M plugins/docman/include/Upload/Document/DocumentBeingUploadedInformationProvider.php +1 −1 Go to diff View file
M plugins/docman/include/Upload/Version/VersionBeingUploadedInformationProvider.php +1 −1 Go to diff View file
M plugins/docman/include/Upload/Version/VersionUploadFinisher.php +1 −3 Go to diff View file
M plugins/docman/include/Version/LinkVersionDataUpdator.php +1 −1 Go to diff View file
M plugins/docman/include/view/Docman_View_Header.class.php +1 −1 Go to diff View file
M plugins/frs/include/FRS/Upload/Tus/FileBeingUploadedInformationProvider.php +1 −1 Go to diff View file
M plugins/frs/include/FRS/Upload/UploadPathAllocator.php +1 −1 Go to diff View file
M plugins/git/bin/gl-rename-project.php +1 −1 Go to diff View file
M plugins/git/include/GitActions.class.php +2 −2 Go to diff View file
M plugins/git/include/GitPHP/Commit/CommitPresenter.php +1 −1 Go to diff View file
M plugins/git/include/GitRepository.class.php +1 −1 Go to diff View file
M plugins/git/phpunit/GitViewsRepositoriesTraversalStrategySelectboxTest.php +1 −1 Go to diff View file
M plugins/graphontrackersv5/include/data-transformation/GraphOnTrackersV5_Chart_BarDataBuilder.class.php +1 −1 Go to diff View file
M plugins/graphontrackersv5/include/data-transformation/GraphOnTrackersV5_Chart_PieDataBuilder.class.php +1 −1 Go to diff View file
M plugins/mediawiki/www/LocalSettings.php +1 −1 Go to diff View file
M plugins/pluginsadministration/include/pluginsadministrationPlugin.php +1 −1 Go to diff View file
M plugins/svn/include/REST/v1/RepositoryResource.php +1 −3 Go to diff View file
M plugins/taskboard/include/Column/ColumnPresenterCollectionRetriever.php +1 −1 Go to diff View file
M plugins/taskboard/include/Tracker/AddInPlaceRetriever.php +1 −1 Go to diff View file
M plugins/textualreport/include/TextualReport/ArtifactsPresentersBuilder.php +1 −1 Go to diff View file
M plugins/tracker/include/REST/v1/TrackerFieldsResource.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetValue_File.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/View/Edit.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/File/AttachmentController.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/File/Upload/Tus/FileBeingUploadedInformationProvider.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/File/Upload/UploadPathAllocator.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report_HeaderRenderer.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/XML/Exporter/ChangesetValueXMLExporterVisitor.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/XML/Updater/FieldChangeXMLUpdaterVisitor.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/PostAction/Update/Internal/FrozenFieldsValueValidator.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/PostAction/Update/Internal/HiddenFieldsetsValueValidator.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/PostAction/Update/Internal/SetDateValueValidator.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/PostAction/Update/Internal/SetFloatValueValidator.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/PostAction/Update/Internal/SetIntValueValidator.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/SimpleMode/State/TransitionExtractor.php +1 −1 Go to diff View file
M plugins/tracker/include/Workflow/Trigger/RulesManager.class.php +2 −1 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +2 −2 Go to diff View file
M plugins/tracker/phpunit/Tracker/FormElement/Field/File/AttachmentForRestCreatorTest.php +6 −6 Go to diff View file
M plugins/tracker/phpunit/Tracker/FormElement/Field/File/AttachmentForTraditionalUploadCreatorTest.php +7 −7 Go to diff View file
M plugins/tracker/phpunit/Tracker/FormElement/Field/File/ChangesetValueFileSaverTest.php +7 −7 Go to diff View file
M plugins/tracker/phpunit/Tracker/Permission/PermissionCheckerTest.php +1 −1 Go to diff View file
M plugins/velocity/include/velocityPlugin.php +1 −1 Go to diff View file
M src/common/Dashboard/AssetsIncluder.php +1 −1 Go to diff View file
M src/common/FRS/FRSFileDownloadController.php +1 −1 Go to diff View file
M src/common/svn/hook/PostRevPropset.class.php +1 −1 Go to diff View file
M src/common/system_event/include/SystemEventUserActiveStatusChange.php +1 −1 Go to diff View file
M src/common/system_event/include/SystemEvent_SYSTEM_CHECK.class.php +1 −1 Go to diff View file
M src/www/admin/system_events/adminPresenter.class.php +1 −1 Go to diff View file
M tests/phpcs/non-psr-rules.xml +2 −0 Go to diff View file
M tests/phpunit/common/Tracker/XML/Exporter/FileInfoXMLExporterTest.php +2 −2 Go to diff View file