Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Prevent edition of the reviewers on a closed PR

Download Browse

In fd6d9296f6e56ecfd0cb48bf23511f1e6dfc7b8c the buttons to edit the list are not visible when the PR is merged but this was not enforced by the REST endpoint. Part of story #14190: get email notifications on pull requests - first stage Change-Id: I5817e400ee68a3ea1555d7c78564ae6d4eca5fe3

+60 −0
Thomas Gerbet (tgerbet) 2019-11-22 11:51
Thomas Gerbet (tgerbet) 2019-11-22 11:51
2503d95d360b93700ab84b6592e0719ca6ab79c2
bb306b56c90a4ae3ca4affac7512a5dd6302eef9
git #tuleap/stable/2503d95d360b93700ab84b6592e0719ca6ab79c2

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +6 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerUpdater.php +5 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/Reviewer/ReviewersCannotBeUpdatedOnClosedPullRequestException.php +36 −0 Go to diff View file
M plugins/pullrequest/phpunit/Reviewer/ReviewerUpdaterTest.php +13 −0 Go to diff View file