Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Unable to open the edit title/description modal anymore

Download Browse

part of part of story #31151 Edit the description comment in text only Looks like it is not possible to inject $element in a TlpModal controller, nor the TlpModal service. This fix makes the overview-controller give the modal a on_success_callback to trigger when the title and description have been successfully saved. This callback loads tooltips present in the area where the description is displayed, to avoid having several instances of the tooltips for every single reference. Change-Id: I33059db0c3897090b4ee8ab2207f792762b9cf31

+11 −14
Thomas Gorka (tgorka) 2023-03-17 10:54
Thomas Gorka (tgorka) 2023-03-17 10:54
275659a16cc06351d3db420208323ddf42504953
c3d0a781b7dcefcabdc58cbd32f2effc859e04fa
git #tuleap/stable/275659a16cc06351d3db420208323ddf42504953

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/edit-modal/edit-modal-controller.js +3 −10 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/edit-modal/edit-modal-service.js +2 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/overview-controller.js +6 −2 Go to diff View file