Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Fix unit test dependency

Download Browse

With usage of includeFooterJavascriptFile the target file must exist on filesystem when the call is made. However it should be possible to run unit tests without having built assets so tests were failling. This commit introduce addJavascriptAsset (mirror of addCssAsset) so resolution of the file can be defered to the very last moment hence unit tests passes again. Part of story #14552 User preferences goes Burning Parrot Change-Id: Iecc64a34d9fb7d236489e248c9205021380e5981

+75 −4
Manuel Vacelet (vaceletm) 2020-02-19 14:00
Manuel Vacelet (vaceletm) 2020-02-19 16:59
27a4b0d22f1ddf0f8462eb61f1d2cffc7562241b
bc938db31859d41125ff914d148412ec1454513f
git #tuleap/stable/27a4b0d22f1ddf0f8462eb61f1d2cffc7562241b

Modified Files

Side by side diff
Inline diff
Name
M src/common/User/Account/DisplayKeysTokensController.php +6 −4 Go to diff View file
M src/common/layout/BaseLayout.php +9 −0 Go to diff View file
A src/common/layout/JavascriptAsset.php +47 −0 Go to diff View file
M src/common/layout/Layout.class.php +3 −0 Go to diff View file
M src/www/themes/BurningParrot/BurningParrotTheme.php +1 −0 Go to diff View file
M src/www/themes/BurningParrot/FooterPresenter.php +9 −0 Go to diff View file