Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class in ReferenceFactory.php

Download Browse

Use the dedicated class instead a god factory to retrieve a pull request by its id. No functionnal change expected, reference should still work as before Part of request #35473 Stop relying on the god PullRequest/Factory class to retrieve pull request Change-Id: Ib55a619bdd225bf58a8d669ebb01e15f22f3dd4d

+66 −111
Clarck Robinson (robinsoc) 2023-12-05 15:04
Clarck Robinson (robinsoc) 2023-12-11 16:57
2805142485aeeae31b663fa9e173d5739fe26a33
88246c33cced8d557ad145c4d7c9035ef33a50ed
git #tuleap/stable/2805142485aeeae31b663fa9e173d5739fe26a33

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Reference/ReferenceFactory.php +26 −45 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +6 −14 Go to diff View file
M plugins/pullrequest/tests/unit/Reference/ReferenceFactoryTest.php +34 −52 Go to diff View file