Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto: DRY of the GitlabGroupLinkRepositoryHandler::integrateOneProject function

Download Browse

Part of story #26799 associate a Tuleap project and a GitLab group This function has been previously duplicated in a dedicated object (GitlabProjectIntegrator) since 3510b646521b1f02b8324f9655dd2cbfd50aaa9c, there is no need of this private method anymore. No functionnal change expected, you should still be able to create new group link, create (if needed) the missing integration and link each integrations (already existing or not) Change-Id: I1e6a826245e54a6131b3a03dce8303aefd17f05f

+150 −209
Clarck Robinson (robinsoc) 2022-10-17 16:47
Clarck Robinson (robinsoc) 2022-10-18 16:31
288c6e75f4adba6110a623cc033dc248e8e93f83
7ee1ba6fea3b57f0dda53416983bdae489ebd39d
git #tuleap/stable/288c6e75f4adba6110a623cc033dc248e8e93f83

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Group/GroupCreator.php +6 −1 Go to diff View file
M plugins/gitlab/include/REST/v1/GitlabGroupResource.php +71 −60 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryGroupLinkHandler.php +17 −61 Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabRepositoryGroupLinkHandlerTest.php +17 −50 Go to diff View file
M plugins/gitlab/tests/unit/Group/GroupCreatorTest.php +15 −29 Go to diff View file
M plugins/gitlab/tests/unit/Repository/GitlabProjectIntegratorTest.php +24 −8 Go to diff View file