stable
Clone or download
Read-only
request #15060: Ban usage of non crypto secure/user-space RNG
For all the use cases encountered in the codebase, random_int() and random_bytes() are better alternatives. This contribution bans the following functions: * rand * mt_rand * srand * mt_srand * openssl_random_pseudo_bytes * uniqid Change-Id: I14a3120df50bac96456a172e70733899efe7e056
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/docman/include/Docman_Token.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitPHP/git/FileDiff.php | +1 | −6 | Go to diff View file |
| M | plugins/git/include/gitPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/Git/Driver/Gerrit/ProjectCreatorCallToGerritTest.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/Git/Driver/Gerrit/ProjectCreatorTest.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/unit/Git_ExecTest.php | +2 | −2 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserWrite.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Migration/V3.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Tracker_ReportFactory.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_CriteriaTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_List_CriteriaTest.php | +2 | −2 | Go to diff View file |
| M | src/common/Project/ProjectCreator.class.php | +1 | −4 | Go to diff View file |
| M | src/common/TreeNode/TreeNode.class.php | +1 | −1 | Go to diff View file |
| M | src/common/collection/LinkedList.class.php | +1 | −1 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/ASCIIMathPHP/ASCIIMathPHP.class.php | +1 | −1 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/DbaDatabase.php | +1 | −1 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/fortune.php | +2 | −3 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/plugin/RandomPage.php | +0 | −1 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/stdlib.php | +1 | −23 | Go to diff View file |
| M | src/common/wiki/phpwiki/passencrypt.php | +3 | −47 | Go to diff View file |
| M | src/db/mysql/updates/2014/201406041516_add_email_gateway_salt.php | +1 | −1 | Go to diff View file |
| M | src/embedded_vendor/jpgraph/jpgraph.php | +1 | −2 | Go to diff View file |
| M | src/www/include/nusoap.php | +8 | −8 | Go to diff View file |
| M | src/www/mail/admin/index.php | +1 | −1 | Go to diff View file |
| M | src/www/project/export/project_export_utils.php | +1 | −24 | Go to diff View file |
| M | tests/lib/TestHelper.class.php | +1 | −16 | Go to diff View file |
| M | tests/phpcs/non-psr-rules.xml | +12 | −0 | Go to diff View file |
| M | tests/unit/common/FRS/FRSFileFactoryTest.php | +2 | −2 | Go to diff View file |
| M | tests/unit/common/valid/ValidHelpersTest.php | +1 | −1 | Go to diff View file |