Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Document the lib to simplify modal opening code

Download Browse

Part of request #14718 DRY TLP modal opening code How to test: - The "Add a new app" button in OAuth2 project admin should still open a modal. - TLP's doc documents the lib and has a (non-working because of imports) example of usage. openModalOnClick() was almost exactly the same as openTargetModalIdOnClick and has been removed in favor of the latter. Change-Id: Ie269b3e3ce90b0d8fd084294a7ed18f223aefec8

+199 −56
Joris MASSON (jmasson) 2020-03-27 17:19
Joris MASSON (jmasson) 2020-03-30 09:30
29a76a1c1e4d289e451fe29f41284502eb3b414e
9a82424347cfb87faea88d2a3bf71489da40de5e
git #tuleap/stable/29a76a1c1e4d289e451fe29f41284502eb3b414e

Modified Files

Side by side diff
Inline diff
Name
M plugins/oauth2_server/scripts/src/project-administration.ts +2 −3 Go to diff View file
M plugins/oauth2_server/templates/project-admin.mustache +6 −1 Go to diff View file
M src/www/scripts/tuleap/modals/modal-opener.test.ts +1 −33 Go to diff View file
M src/www/scripts/tuleap/modals/modal-opener.ts +0 −11 Go to diff View file
M src/www/themes/common/tlp/doc/resources/flyover/modals/manifest.json +10 −8 Go to diff View file
A src/www/themes/common/tlp/doc/resources/flyover/modals/open-target/doc.html +17 −0 Go to diff View file
A src/www/themes/common/tlp/doc/resources/flyover/modals/open-target/example.html +38 −0 Go to diff View file
A src/www/themes/common/tlp/doc/resources/flyover/modals/replace-placeholders/doc.html +29 −0 Go to diff View file
A src/www/themes/common/tlp/doc/resources/flyover/modals/replace-placeholders/example.html +96 −0 Go to diff View file