Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #11687: Drop SHA1 polyfill

Download Browse

sha1() is available since PHP 4.3.0 (and should not be used nowadays) there is no need for this polyfill. Also, it is expected from implementation of cryptographic functions to be constant-time, this implementation is not (information is leaked by functions like chr() and ord() that uses a lookup table and so can be exploited by processor cache misses). Change-Id: Ia2dda408f8075c67539aa248aa2e354181e2dab0

+0 −284
Thomas Gerbet (tgerbet) 2018-06-25 17:54
Thomas Gerbet (tgerbet) 2018-06-25 17:54
2a3e5314d21d22c6fb6411e32fbd10b2992b3f7b
c37850ca9ddbb88393675b289fec9f462cc5260c
git #tuleap/stable/2a3e5314d21d22c6fb6411e32fbd10b2992b3f7b

Modified Files

Side by side diff
Inline diff
Name
M plugins/IM/include/jabbex_api/lib/jabberclass-0.9/class_Jabber.php +0 −20 Go to diff View file
D plugins/IM/include/jabbex_api/lib/jabberclass-0.9/class_SHA1Library.php +0 −264 Go to diff View file